Fix Promotion Eligiblity for already promoted users#2270
Open
saisandeepkoritala wants to merge 2 commits into
Open
Fix Promotion Eligiblity for already promoted users#2270saisandeepkoritala wants to merge 2 commits into
saisandeepkoritala wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a user is already a "Promoted Reviewer" we should not fetch them or show them in the ui. As they have been already promoted.
Related PRS (if any):
This is related to Frontend PR 4810.You need to check into this backend to properly test PR 4810.
…
Main changes explained:
How to test:
npm install,npm run buildandnpm startto run this PR locally ( for mac, linux)npm install,npm run build:windowsandnpm startto run this PR locally ( for windows user's)